fix(build): compile the Solid 2 JSX transform, and declare the peers it needs - #243
Merged
Conversation
…it needs The consumer smoke test was failing on a package that built cleanly here, which is exactly the gap it exists to close. Four separate faults, each hidden behind the one before it. @rsbuild/plugin-solid depends on babel-preset-solid ^1.9.12, a range semver cannot cross to 2.0.0-rc.0, so bun installed a nested Solid 1 preset under the plugin and the plugin's own require.resolve loaded that one regardless of what this package hoisted. The Solid 1 transform emits imports from solid-js/web, a subpath Solid 2 dropped, and a use helper Solid 2 does not export. An override plus moduleName pins the transform to the Solid 2 one across all 130 generated files. Same shape as the solid-layouts-oxc nesting, and the same lesson: an exact or narrow pin in a dependency is not overridden by hoisting. The peer ranges then said solid-layouts ^0.1.3 and solid-js ^1.9, neither of which admits what the emitted code imports: 0.1.x ships no ./solid-2 export, and 1.9 has no omit or createOwner for @solidjs/web to bind to. A consumer installing the declared peers got a package that could not resolve. The smoke fixture also still imported useTableModel, removed with TanStack, and set jsxImportSource to solid-js, whose jsx-runtime Solid 2 moved to @solidjs/web.
pathscale
force-pushed
the
fix/solid-2-transform
branch
from
August 16, 2026 10:33
afdb4b8 to
47e9040
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The consumer smoke test was failing on
masterafter #242 merged, on a package that builds cleanly in-repo. Four faults, each hidden behind the one before it.1. The Solid 1 JSX transform was still running.
@rsbuild/plugin-soliddepends onbabel-preset-solid: ^1.9.12, a range semver cannot cross to2.0.0-rc.0, so bun installed a nested Solid 1 preset under the plugin and the plugin's ownrequire.resolveloaded that one no matter what this package hoisted. The Solid 1 transform emitssolid-js/web(a subpath Solid 2 dropped) and ausehelper Solid 2 does not export. Anoverridesentry plusmoduleNamepins the transform to Solid 2 across all 130 generated files.Same shape as the
solid-layouts-oxcnesting fixed last week, and the same lesson: a narrow pin inside a dependency is not overridden by hoisting.2 and 3. The peer ranges did not admit what the emitted code imports.
solid-layouts: ^0.1.3ships no./solid-2export, andsolid-js: ^1.9has noomit/createOwnerfor@solidjs/webto bind to. A consumer installing the declared peers got a package that could not resolve.4. The smoke fixture was stale — it imported
useTableModel(removed with TanStack) and setjsxImportSource: solid-js, whosejsx-runtimeSolid 2 moved to@solidjs/web.Verified:
bun run smokepasses end to end (install, typecheck, bundle), 90/90 contract checks, and the emitted import is@solidjs/webwith zerouseimports remaining.🤖 Generated with Claude Code